Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/CAT-937 Sort publications by their publication date, convert related hooks to TypeScript #3565

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

NickAkhmetov
Copy link
Collaborator

@NickAkhmetov NickAkhmetov commented Oct 8, 2024

Summary

This PR updates the publications landing page so that publications and preprints are always sorted by their publication date, descending. This functionality was achieved by adding a sort field to the related query.

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-937

Testing

Compared local to production.

Screenshots/Video

Production: https://portal.hubmapconsortium.org/publications
image

Local with fix:
image

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Additional Notes

},
},
{
term: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is publicationStatus always one value or can it be multiple?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This query is specific to one publication status at a time based on the currently selected tab on the page (publication or preprint).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. In that case, the query looks good to me!

@NickAkhmetov NickAkhmetov merged commit 0993776 into main Oct 9, 2024
8 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/cat-937-publication-sorting branch October 9, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants