Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/CAT-937 Sort publications by their publication date, convert related hooks to TypeScript #3565

Merged
merged 1 commit into from
Oct 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-cat-937.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Sort publications by their date of publication.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
import useSearchData from 'js/hooks/useSearchData';
import { fetcher } from 'js/helpers/swr';
import { SearchRequest, SearchResponse } from '@elastic/elasticsearch/lib/api/types';
import { buildPublicationPanelProps, PublicationHit } from './utils';

const getPublicationsByStatusQuery: (publicationStatus: string) => SearchRequest = (publicationStatus) => ({
query: {
bool: {
must: [
{
term: {
'entity_type.keyword': 'Publication',
},
},
{
term: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is publicationStatus always one value or can it be multiple?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This query is specific to one publication status at a time based on the currently selected tab on the page (publication or preprint).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. In that case, the query looks good to me!

publication_status: publicationStatus,
},
},
],
},
},
sort: [
{
'publication_date.keyword': {
order: 'desc',
},
},
],
size: 10000,
_source: ['uuid', 'title', 'contributors', 'publication_status', 'publication_venue', 'publication_date'],
});

async function fetchPublicationsPanelData(args: Parameters<typeof fetcher>[0]) {
const results = await fetcher<SearchResponse<PublicationHit['_source']>>(args);
const unwrappedResults = results?.hits?.hits.map((hit) => hit._source!);
if (!unwrappedResults) {
return [];
}
return unwrappedResults.map((hit) => buildPublicationPanelProps({ _source: hit }));
}

function usePublicationsPanelList(publicationStatus: string) {
const query = getPublicationsByStatusQuery(publicationStatus);

const { searchData: publicationPanelsProps, isLoading } = useSearchData<PublicationHit, unknown>(query, {
useDefaultQuery: true,
fetcher: fetchPublicationsPanelData,
fallbackData: [],
});

return { publicationPanelsProps, isLoading };
}

export { usePublicationsPanelList };
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function buildSecondaryText(contributors: Contributor[], publication_venue: stri
.join(' | ');
}

interface PublicationHit {
export interface PublicationHit {
_source: {
uuid: string;
title: string;
Expand Down
Loading