Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/CAT-948 restore missing columns in derived entities tables #3567

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

NickAkhmetov
Copy link
Collaborator

Summary

This PR restores the status column for derived datasets and the organ column for derived samples.

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-948

Testing

Manual testing

Screenshots/Video

Prod link: https://portal.hubmapconsortium.org/browse/donor/be425f8a2963dda1d3a7a0c79de5e466#derived-data

Fixed screenshots:
image

image

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

@tkakar
Copy link
Collaborator

tkakar commented Oct 10, 2024

Neat fix. looks good to me.

Copy link
Collaborator

@austenem austenem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@NickAkhmetov NickAkhmetov merged commit e07978c into main Oct 11, 2024
8 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/cat-948 branch October 11, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants