Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear help msg for ignore_eos to avoid misunderstanding #1141

Merged
merged 2 commits into from
Aug 8, 2024
Merged

clear help msg for ignore_eos to avoid misunderstanding #1141

merged 2 commits into from
Aug 8, 2024

Conversation

sywangyi
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@sywangyi sywangyi requested a review from regisss as a code owner July 18, 2024 02:33
@sywangyi
Copy link
Collaborator Author

@regisss please help review

ssarkar2
ssarkar2 reviewed Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@ssarkar2 ssarkar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying the help msg. Some minor comments

examples/language-modeling/README.md Show resolved Hide resolved
examples/text-generation/run_generation.py Show resolved Hide resolved
@libinta
Copy link
Collaborator

libinta commented Jul 24, 2024

@sywangyi can you fix the review comments?

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@regisss regisss merged commit 2f8ea07 into main Aug 8, 2024
6 checks passed
@regisss regisss deleted the fix_doc branch August 8, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssarkar2 ssarkar2 ssarkar2 approved these changes

@regisss regisss regisss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sywangyi @libinta @HuggingFaceDocBuilderDev @regisss @ssarkar2