Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear help msg for ignore_eos to avoid misunderstanding #1141

Merged
merged 2 commits into from
Aug 8, 2024
Merged

clear help msg for ignore_eos to avoid misunderstanding #1141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ed3803
clear help msg for ignore_eos to avoid misunderstanding
sywangyi Jul 18, 2024
408ffc2
Merge branch 'main' into fix_doc
regisss Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/image-to-text/run_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def main():
parser.add_argument(
"--ignore_eos",
action="store_true",
help="Whether to ignore eos, set False to disable it.",
help="Whether to disable stopping with eos token when calling `generate`.",
)
parser.add_argument(
"--use_flash_attention",
Expand Down
2 changes: 1 addition & 1 deletion examples/language-modeling/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@ python3 ../text-generation/run_generation.py \
--use_kv_cache \
--batch_size 1 \
--use_hpu_graphs \
--ignore_eos \
--no-ignore_eos \
sywangyi marked this conversation as resolved.
Show resolved Hide resolved
--peft_model prompt_tuning_out \
--prompt "@SEPTA_SOCIAL Ok. Thanks. Label :"

Expand Down
2 changes: 1 addition & 1 deletion examples/text-generation/run_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ def setup_parser(parser):
"--ignore_eos",
default=True,
action=argparse.BooleanOptionalAction,
help="Whether to ignore eos, set False to disable it",
help="Whether to disable stopping with eos token when calling `generate`. --no-ignore_eos to disable it",
sywangyi marked this conversation as resolved.
Show resolved Hide resolved
)
parser.add_argument("--temperature", default=1.0, type=float, help="Temperature value for text generation")
parser.add_argument("--top_p", default=1.0, type=float, help="Top_p value for generating text via sampling")
Expand Down
Loading