feat: add join_multiset() #804
Conversation
also remove documentation about HalfJoinMultiset, the way to access that now is to use join_multiset()
|
|
||
| /// > 2 input streams of type <(K, V1)> and <(K, V2)>, 1 output stream of type <(K, (V1, V2))> | ||
| /// | ||
| /// This operator is equivalent to `join` except that the LHS and RHS are collected into multisets rather than sets before joining. |
There was a problem hiding this comment.
hmm order is preserved I think so multisets might not be the right word
There was a problem hiding this comment.
Given that there are many (multiset) join algorithms, that seems like a side-effect of the implementation that we may not want to provide as a guarantee, so I wouldn't sweat it.
|
|
||
| /// > 2 input streams of type <(K, V1)> and <(K, V2)>, 1 output stream of type <(K, (V1, V2))> | ||
| /// | ||
| /// This operator is equivalent to `join` except that the LHS and RHS are collected into multisets rather than sets before joining. |
There was a problem hiding this comment.
Given that there are many (multiset) join algorithms, that seems like a side-effect of the implementation that we may not want to provide as a guarantee, so I wouldn't sweat it.
| /// For example: | ||
| /// ```hydroflow | ||
| /// lhs = source_iter([("a", 0), ("a", 0)]) -> tee(); | ||
| /// rhs = source_iter([("a", 0)]) -> tee(); |
There was a problem hiding this comment.
I'd encourage you to make the RHS distinguishable to avoid confusion in the example.
rhs = source_iter(["a", "hydro")]) -> tee();
There was a problem hiding this comment.
@zzlk please fix the assert below the code as well
|
Or in a separate commit |
I think we can do it later. I removed the documentation for it so people shouldn't use it. The equivalent functionality is now expoed via join_multiset(); And we also need it because the way join_multiset works is just by generating join::(); |
* feat: add join_multiset() also remove documentation about HalfJoinMultiset, the way to access that now is to use join_multiset() * address comments * fix assert
* feat: add join_multiset() also remove documentation about HalfJoinMultiset, the way to access that now is to use join_multiset() * address comments * fix assert
also remove documentation about HalfJoinMultiset, the way to access that now is to use join_multiset()
fixes #802