Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overrides for interior partitions #46

Merged

Conversation

nadiia-volyk
Copy link
Contributor

@nadiia-volyk nadiia-volyk commented Jun 26, 2023

This change is Reviewable

Copy link
Contributor

@serenayl serenayl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also test the use case where we already have a bunch of walls (like in the Space Planning template sample project) and then we start to cut them up?

When I split my first wall, every other wall immediately became solid.

Reviewed 13 of 15 files at r1.
Reviewable status: 0 of 1 approvals obtained, all discussions resolved

Copy link
Contributor Author

@nadiia-volyk nadiia-volyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this case and it worked fine previously. But something has changed with overrides. After split all edit overrides values have only line(number 6 on image). If I edit wall type manually, it has type and id(number 7)
image.png

Reviewable status: 0 of 1 approvals obtained, all discussions resolved

@ikeough ikeough mentioned this pull request Oct 30, 2023
@anthonie-kramer anthonie-kramer merged commit c669007 into master Dec 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants