Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: WarpModule with update() IsmConfig #3678

Merged
merged 102 commits into from
Jul 3, 2024
Merged

feat: WarpModule with update() IsmConfig #3678

merged 102 commits into from
Jul 3, 2024

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Apr 29, 2024 •
edited
Loading

Description

Implement WarpModule update() with IsmConfig

Drive-by changes

Related issues

Backward compatibility

Yes

Testing

Unit Tests

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 724773f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/core Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ltyu ltyu changed the title Saving initial work Implement WarpCrudModule Apr 30, 2024
@ltyu ltyu changed the title Implement WarpCrudModule Implement WarpCrudModule create() and update() Apr 30, 2024
paulbalaji and others added 7 commits April 30, 2024 16:55
@paulbalaji
draft push
8ac752b
@ltyu
Add read to WarpCrud, change totalSupply to use zod schema type, some…
3686051 
… broken tests
@ltyu
Derive WarpConfig from TokenRouter address (#3671)
2c74413 
### Description
Add Reader to derive WarpConfig from TokenRouter address

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues

- Fixes #3579 

### Backward compatibility
Yes

### Testing

Unit Tests
@ltyu
Saving initial work
fc4a8a4
@ltyu
Add read to WarpCrud, change totalSupply to use zod schema type, some…
4da8778 
… broken tests
@ltyu
Fix unit tests. Incorporate some of Paul's Abstract CrudModule changes
0ccaa38
@ltyu
fix conflicts
3632eb8
@ltyu ltyu requested a review from paulbalaji April 30, 2024 21:41
ltyu and others added 18 commits April 30, 2024 17:56
@ltyu
Re-add a few more overwritten merge lines
2c524cc
@ltyu
Add EvmERC20WarpCrudModule.create()
186a185
@ltyu
Add deploy given an Ism Object
635ccf3
@paulbalaji
draft push
10bd6cb
@paulbalaji
split deploy/update in EvmIsmCreator
0378f8c 
Signed-off-by: Paul Balaji <[email protected]>
@ltyu
Add update logic for Hook and ISM. This commit excludes working logic…
e140813 
… for create ISM
@ltyu
Fix conflicts
9b0a464
@ltyu
Fix conflicts
707967e
@ltyu
Derive WarpConfig from TokenRouter address (#3671)
d40417f 
### Description
Add Reader to derive WarpConfig from TokenRouter address

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues

- Fixes #3579 

### Backward compatibility
Yes

### Testing

Unit Tests
@ltyu
Saving initial work
f32e5fc
@ltyu
Derive WarpConfig from TokenRouter address (#3671)
cd2e1a6 
Add Reader to derive WarpConfig from TokenRouter address

<!--
Are there any minor or drive-by changes also included?
-->

- Fixes #3579

Yes

Unit Tests
@ltyu
Saving initial work
062a00b
@ltyu
Add read to WarpCrud, change totalSupply to use zod schema type, some…
76eb931 
… broken tests
@ltyu
Fix unit tests. Incorporate some of Paul's Abstract CrudModule changes
4e30f18
@ltyu
Add read to WarpCrud, change totalSupply to use zod schema type, some…
d4cb141 
… broken tests
@ltyu
Re-add a few more overwritten merge lines
c3ae3bf
@ltyu
Add EvmERC20WarpCrudModule.create()
fdc41f4
@ltyu
Add deploy given an Ism Object
1efd295
@ltyu ltyu force-pushed the warpCrudModule branch from 9e93f99 to 6a904cd Compare June 12, 2024 19:55
@ltyu ltyu mentioned this pull request Jun 21, 2024
Merged
Base automatically changed from cli-2.0 to main June 27, 2024 13:52
@ltyu Graphite App
Copy link
Contributor Author

ltyu commented Jul 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ltyu and the rest of your teammates on Graphite Graphite

@ltyu ltyu mentioned this pull request Jul 1, 2024
Closed
@ltyu ltyu force-pushed the warpCrudModule branch from 70f0ad0 to ef1d01a Compare July 2, 2024 19:42
@ltyu ltyu enabled auto-merge July 3, 2024 14:35
@ltyu ltyu added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit 1687fca Jul 3, 2024
36 of 37 checks passed
@ltyu ltyu deleted the warpCrudModule branch July 3, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorhodes yorhodes yorhodes left review comments

@jmrossy jmrossy jmrossy left review comments

@paulbalaji paulbalaji paulbalaji approved these changes

@nbayindirli nbayindirli Awaiting requested review from nbayindirli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ltyu @jmrossy @yorhodes @paulbalaji @nbayindirli