Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use middleware submission tweaks #5100

Merged
merged 15 commits into from
Jan 13, 2025
Merged

fix: use middleware submission tweaks #5100

merged 15 commits into from
Jan 13, 2025

Conversation

daniel-savu
Copy link
Contributor

@daniel-savu daniel-savu commented Jan 2, 2025

Description

Uses the short-term fixes described in this design doc and implemented in hyperlane-xyz/ethers-rs#23

These fixes are expected to make the relayer self-recover from nonce gaps.

An expected drawback is that tx hashes are dropped more often due to the nonce manager resyncing to nonces that end up being too low by 1, which can slow down submissions. After 12h of testing, any submit queue spikes were only 1 min long and the biggest one had 7 messages - so short enough not to trigger the "rising submit queue" alert which stays pending for 6min: https://abacusworks.grafana.net/alerting/de6hwplr7eakgc

Drive-by changes

  • Removes verbosity from a bunch of logs (we had HyperlaneMessage in a single log occur 6-7 times, but wasn't noticeable in spans because it was originating from args named message which have a clash with inner workings of the tracing lib)
  • rewords some logs because they were misleading

Related issues

Fixes: #5107

Backward compatibility

Yes

Testing

E2E with a gas escalator that randomly dropped every other tx - the nonce manager was able to recover but was slower to submit. Then evaluated on RC for 12h as described above.

Copy link

changeset-bot bot commented Jan 2, 2025

⚠️ No Changeset found

Latest commit: f3c113b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (1c652a6) to head (f3c113b).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5100   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@daniel-savu daniel-savu changed the title wip: use middleware submission tweaks fix: use middleware submission tweaks Jan 10, 2025
@daniel-savu daniel-savu marked this pull request as ready for review January 10, 2025 12:08
@daniel-savu daniel-savu requested a review from tkporter as a code owner January 10, 2025 12:08
@daniel-savu daniel-savu added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit abb5a8b Jan 13, 2025
42 checks passed
@daniel-savu daniel-savu deleted the dan/submission-tweaks branch January 13, 2025 12:21
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
### Description

To include the changes from
#5100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ethers middleware short term fixes
2 participants