Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use middleware submission tweaks #5100

Merged
merged 15 commits into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions rust/main/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions rust/main/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -198,27 +198,27 @@ overflow-checks = true
[workspace.dependencies.ethers]
features = []
git = "https://github.com/hyperlane-xyz/ethers-rs"
tag = "2025-01-09"
tag = "2025-01-10"

[workspace.dependencies.ethers-contract]
features = ["legacy"]
git = "https://github.com/hyperlane-xyz/ethers-rs"
tag = "2025-01-09"
tag = "2025-01-10"

[workspace.dependencies.ethers-core]
features = []
git = "https://github.com/hyperlane-xyz/ethers-rs"
tag = "2025-01-09"
tag = "2025-01-10"

[workspace.dependencies.ethers-providers]
features = []
git = "https://github.com/hyperlane-xyz/ethers-rs"
tag = "2025-01-09"
tag = "2025-01-10"

[workspace.dependencies.ethers-signers]
features = ["aws"]
git = "https://github.com/hyperlane-xyz/ethers-rs"
tag = "2025-01-09"
tag = "2025-01-10"

[patch.crates-io.curve25519-dalek]
branch = "v3.2.2-relax-zeroize"
Expand Down
2 changes: 1 addition & 1 deletion rust/main/agents/relayer/src/msg/metadata/aggregation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ impl AggregationIsmMetadataBuilder {

#[async_trait]
impl MetadataBuilder for AggregationIsmMetadataBuilder {
#[instrument(err, skip(self), ret)]
#[instrument(err, skip(self, message), ret)]
#[allow(clippy::blocks_in_conditions)] // TODO: `rustc` 1.80.1 clippy issue
async fn build(
&self,
Expand Down
4 changes: 2 additions & 2 deletions rust/main/agents/relayer/src/msg/metadata/base.rs
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ impl Deref for MessageMetadataBuilder {

#[async_trait]
impl MetadataBuilder for MessageMetadataBuilder {
#[instrument(err, skip(self), fields(destination_domain=self.destination_domain().name()))]
#[instrument(err, skip(self, message), fields(destination_domain=self.destination_domain().name()))]
daniel-savu marked this conversation as resolved.
Show resolved Hide resolved
async fn build(
&self,
ism_address: H256,
Expand Down Expand Up @@ -228,7 +228,7 @@ impl MessageMetadataBuilder {
}
}

#[instrument(err, skip(self), fields(destination_domain=self.destination_domain().name()), ret)]
#[instrument(err, skip(self, message), fields(destination_domain=self.destination_domain().name()), ret)]
pub async fn build_ism_and_metadata(
&self,
ism_address: H256,
Expand Down
2 changes: 1 addition & 1 deletion rust/main/agents/relayer/src/msg/metadata/ccip_read.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ pub struct CcipReadIsmMetadataBuilder {

#[async_trait]
impl MetadataBuilder for CcipReadIsmMetadataBuilder {
#[instrument(err, skip(self))]
#[instrument(err, skip(self, message))]
async fn build(
&self,
ism_address: H256,
Expand Down
2 changes: 1 addition & 1 deletion rust/main/agents/relayer/src/msg/metadata/routing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ pub struct RoutingIsmMetadataBuilder {

#[async_trait]
impl MetadataBuilder for RoutingIsmMetadataBuilder {
#[instrument(err, skip(self), ret)]
#[instrument(err, skip(self, message), ret)]
#[allow(clippy::blocks_in_conditions)] // TODO: `rustc` 1.80.1 clippy issue
async fn build(
&self,
Expand Down
2 changes: 1 addition & 1 deletion rust/main/agents/relayer/src/msg/op_submitter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ impl OperationBatch {
};

if !excluded_ops.is_empty() {
warn!(excluded_ops=?excluded_ops, "Either the batch tx would revert, or the operations would revert in the batch. Falling back to serial submission.");
warn!(excluded_ops=?excluded_ops, "Either operations reverted in the batch or the txid wasn't included. Falling back to serial submission.");
OperationBatch::new(excluded_ops, self.domain)
.submit_serially(prepare_queue, confirm_queue, metrics)
.await;
Expand Down
2 changes: 1 addition & 1 deletion rust/main/agents/relayer/src/msg/pending_message.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pub const CONFIRM_DELAY: Duration = if cfg!(any(test, feature = "test-utils")) {
// Wait 5 seconds after submitting the message before confirming in test mode
Duration::from_secs(5)
} else {
// Wait 1 min after submitting the message before confirming in normal/production mode
// Wait 10 min after submitting the message before confirming in normal/production mode
Duration::from_secs(60 * 10)
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ impl<M> AggregationIsm for EthereumAggregationIsm<M>
where
M: Middleware + 'static,
{
#[instrument(err)]
#[instrument(err, skip(self, message))]
#[allow(clippy::blocks_in_conditions)] // TODO: `rustc` 1.80.1 clippy issue
async fn modules_and_threshold(
&self,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ impl<M> MultisigIsm for EthereumMultisigIsm<M>
where
M: Middleware + 'static,
{
#[instrument(err)]
#[instrument(err, skip(self, message))]
#[allow(clippy::blocks_in_conditions)] // TODO: `rustc` 1.80.1 clippy issue
async fn validators_and_threshold(
&self,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ impl<M> RoutingIsm for EthereumRoutingIsm<M>
where
M: Middleware + 'static,
{
#[instrument(err)]
#[instrument(err, skip(self, message))]
#[allow(clippy::blocks_in_conditions)] // TODO: `rustc` 1.80.1 clippy issue
async fn route(&self, message: &HyperlaneMessage) -> ChainResult<H256> {
let ism = self
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ pub fn termination_invariants_met(
)?;
assert!(!lengths.is_empty(), "Could not find queue length metric");
if lengths.iter().sum::<u32>() != ZERO_MERKLE_INSERTION_KATHY_MESSAGES {
log!("Relayer queues not empty. Lengths: {:?}", lengths);
log!(
"Relayer queues contain more messages than the zero-merkle-insertion ones. Lengths: {:?}",
lengths
);
return Ok(false);
};

Expand Down
Loading