Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor dispatchers to be beetter #7331

Merged
merged 6 commits into from
Aug 24, 2024

Conversation

ikalco
Copy link
Contributor

@ikalco ikalco commented Aug 14, 2024

Describe your PR, what does it fix/add?

will fix #7135
allow for better error messages from dispatchers, for hyprctl
also allow them to specify whether to pass the keybind event or not

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

  • move some keybindManager debug log errors to SDipatchResult error and print them somewhere else
  • make hyprctl use the errors too
  • the rest of the dispatchers

Is it ready for merging, or does it need work?

yea, but review

also sorry for massive pr but its mostly replacing return; with return {}; or
return {.success = false, error = "whatever the log above it was"}

@ikalco ikalco changed the title move half da dispatchers to refactor refactor dispatchers to be beetter Aug 14, 2024
@ikalco ikalco force-pushed the refactor_dispatchers_with_errs branch from eab8af3 to 68ab75e Compare August 22, 2024 04:07
@github-actions github-actions bot added the debug label Aug 22, 2024
@ikalco ikalco marked this pull request as ready for review August 22, 2024 23:33
@vaxerski
Copy link
Member

beeter

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review the actual errors once I am on my desktop tomorrow

src/plugins/PluginAPI.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the boring ass work!

@vaxerski vaxerski merged commit 66586c3 into hyprwm:main Aug 24, 2024
10 checks passed
@ikalco ikalco deleted the refactor_dispatchers_with_errs branch August 24, 2024 19:16
m4r1vs pushed a commit to m4r1vs/Hyprland that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wvkbd
2 participants