animation: fixup adding animvars during ::tick #9030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaideiaDilemma
force-pushed
the
fixup-animation-callback-safety
branch
from
fc4b62e to
8c762c5
Compare
littleblack111
pushed a commit
to littleblack111/Hyprland
that referenced
this pull request
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Removes the FIXME regarding adding animvars via callbacks during a tick.
Looping via indices resolves the problem when vars get added to active via a callback.
Vars are only actively removed from
m_vActiveAnimatedVaraiblesvia the dtor ofCBaseAnimatedVariable. But aCBaseAnimatedVariablecan't be deleted during a callback, since we own a SP to it when calling the callback in the first place. So having elements ofm_vActiveAnimatedVariablesbe removed via a callback during::tickis currently not possible anyways.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No.
Is it ready for merging, or does it need work?
Ready.