Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animation: fixup adding animvars during ::tick #9030

Merged
merged 1 commit into from
Jan 11, 2025
+2 −5
Merged

animation: fixup adding animvars during ::tick #9030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/managers/AnimationManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,11 +216,8 @@ void CHyprAnimationManager::tick() {

static auto PANIMENABLED = CConfigValue<Hyprlang::INT>("animations:enabled");

// We need to do this because it's perfectly valid to add/change a var during this (via callbacks)
// FIXME: instead of doing this, make a fn to defer adding until tick is done and not in progress anymore.
const auto PAVS = m_vActiveAnimatedVariables;
for (auto const& pav : PAVS) {
const auto PAV = pav.lock();
for (size_t i = 0; i < m_vActiveAnimatedVariables.size(); i++) {
const auto PAV = m_vActiveAnimatedVariables[i].lock();
if (!PAV)
continue;

Expand Down
Loading