BDA #310
Merged
BDA #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Michael, can you fix the linting issues and let me know once the pull request is ready for review? |
marcosertoli
approved these changes
Feb 7, 2024
indica/readers/read_st40.py
Outdated
| @@ -129,8 +129,8 @@ def get_raw_data(self, uid: str, instrument: str, revision: RevisionLike = 0): | |||
| continue | |||
|
|
|||
| transform = data[quant].transform | |||
| if hasattr(transform, "set_equilibrium"): | |||
| transform.set_equilibrium(self.equilibrium) | |||
| # if hasattr(transform, "set_equilibrium"): | |||
There was a problem hiding this comment.
This is needed in a few workflows that don't have tests yet :-(.
I'll reinstate it with a keyword set to False by default so your stuff doesn't have to be changed.
We anyway have to refactor this wrapper in the next weeks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working version of BDA. Other than the BDA specific blocks I made some smallish changes to the Plasma class.
Still fixing the linting / tests