-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add click through announcement feature #6821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I have one question and one non-blocking suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but had a few suggestions that may be worth considering to avoid potential conflicts between serverless and oss.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Seems like the ci tests failure is a legit one. After you fix that, it should be good to go
This PR adds a new feature to Serverless, the click-through announcement. It is used for important announcements that users must see and includes event tracking for interacting with the announcement component.
The first announcement is for the PAYG pricing increase. There is also a banner on the billing page regarding this announcement. Both of these are limited to direct signup PAYG users.
Checklist
Authors and Reviewer(s), please verify the following: