Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add click through announcement feature #6821

Merged
merged 11 commits into from
Oct 24, 2023

Conversation

mavarius
Copy link
Collaborator

@mavarius mavarius commented Oct 18, 2023

This PR adds a new feature to Serverless, the click-through announcement. It is used for important announcements that users must see and includes event tracking for interacting with the announcement component.

The first announcement is for the PAYG pricing increase. There is also a banner on the billing page regarding this announcement. Both of these are limited to direct signup PAYG users.

image image

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Feature flagged, if applicable

@mavarius mavarius requested a review from a team as a code owner October 18, 2023 22:46
Copy link
Contributor

@appletreeisyellow appletreeisyellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I have one question and one non-blocking suggestion

Copy link
Contributor

@wdoconnell wdoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but had a few suggestions that may be worth considering to avoid potential conflicts between serverless and oss.

Copy link
Contributor

@appletreeisyellow appletreeisyellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Seems like the ci tests failure is a legit one. After you fix that, it should be good to go

src/billing/components/PayAsYouGo/PricingAlert.tsx Outdated Show resolved Hide resolved
@mavarius mavarius added this pull request to the merge queue Oct 24, 2023
Merged via the queue into master with commit 96b4be3 Oct 24, 2023
6 checks passed
@mavarius mavarius deleted the feat/price-change-announcement branch October 24, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants