Add Rate limiter #579
Merged
Add Rate limiter #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worryg0d
reviewed
Sep 27, 2023
pkg/ratelimiter/interfaces.go
Outdated
Comment on lines
5
to
13
| type RateLimiter interface { | ||
| // When gets an item and gets to decide how long that item should wait | ||
| When(item interface{}) time.Duration | ||
| // Forget indicates that an item is finished being retried. Doesn't matter whether it's for failing | ||
| // or for success, we'll stop tracking it | ||
| Forget(item interface{}) | ||
| // NumRequeues returns back how many failures the item has had | ||
| NumRequeues(item interface{}) int | ||
| } |
There was a problem hiding this comment.
What is the point of duplicating the controller.RateLimiter interface? If you want to avoid using the controller package prefix, you can just create an alias for it type RateLimiter = controller.RateLimiter
There was a problem hiding this comment.
For now, there is no use for duplicating it. I probably remove it.
pkg/ratelimiter/rate_limiter.go
Outdated
Comment on lines
25
to
34
| func NewItemExponentialFailureRateLimiterWithMaxTries(baseDelay time.Duration, maxDelay time.Duration) RateLimiter { | ||
| return &ItemExponentialFailureRateLimiterWithMaxTries{ | ||
| failures: map[interface{}]int{}, | ||
| baseDelay: baseDelay, | ||
| maxDelay: maxDelay, | ||
| maxTries: defaultMaxTries, | ||
| } | ||
| } |
There was a problem hiding this comment.
I think it would be better if there was an opportunity to configure maxRetries myself. If it is not configured then set defaultMaxTries value
There was a problem hiding this comment.
Not sure about the idea of configuring the maxTries. I think it's more of a generic thing. But let's get another opinion about this.
ribaraka
force-pushed
the
rate_limiter
branch
5 times, most recently
from
065d65d to
25fad97
Compare
worryg0d
approved these changes
Sep 29, 2023
testisnullus
approved these changes
Sep 29, 2023
tengu-alt
approved these changes
Sep 29, 2023
taaraora
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #559
Custom Rate Limiter (CRL) with several features:
CRL is built on the
controller-runtimeframework. For the CRL proper work, all controllers, in case of an error, should now return errors, instead ofnil.Refactored the Cassandra controller, for the CRL's capabilities and suits as an example for further refactoring and CRL integration.
ReconcileReque60now works only in case of possible Kubernetes error.