add smoketest for basic training runs #398
Draft
+162
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a singular smoketest that will run "training" on the sample data that we have in this repo. This iteration of the training loop has minimal features- no LoRA, no CPU offloading, no flash-attention. (i.e. minimal external dependencies).
It does require four GPUs, however, as a default. Currently it takes about six minutes to finish on a 4xL40s machine because the sample dataset has been truncated by only accepting samples that have a sequence length of <160 tok.
It executes:
It includes boilerplate for future feature-coverage tests that include stuff like LoRA or CPU offloading.
The intention is that this test (and following tests like it) should be run less frequently than traditional unit tests, linting, and static code analysis (hence the
@pytest.mark.slow
decorator) but should still give a clear indication, later in the PR review process, that our features will run to completion without obvious problems.