Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update how to guides #523

Merged
merged 8 commits into from
Sep 16, 2022
Merged

Update how to guides #523

merged 8 commits into from
Sep 16, 2022

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Sep 16, 2022 •
edited by mgrover1
Loading

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

mgrover1
mgrover1 reviewed Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments and suggestions

docs/source/how-to/build-a-catalog-from-timeseries-files.md Outdated Show resolved Hide resolved
docs/source/how-to/build-a-catalog-from-timeseries-files.md Outdated Show resolved Hide resolved
@andersy005 andersy005 marked this pull request as ready for review September 16, 2022 22:09
@andersy005 andersy005 added the documentation Documentation related label Sep 16, 2022
mgrover1
mgrover1 reviewed Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question/suggestion

docs/source/how-to/modify-catalog.md Outdated Show resolved Hide resolved
@mgrover1 mgrover1 mentioned this pull request Sep 16, 2022
Open
13 tasks
mgrover1
mgrover1 approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @andersy005 ! Looks great!

@mgrover1 mgrover1 merged commit 80b49d1 into main Sep 16, 2022
@mgrover1 mgrover1 deleted the modifying-catalog branch September 16, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

Assignees
No one assigned
Labels
documentation Documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andersy005 @mgrover1