Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to correct cat_subset representation output #673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sadielbartholomew
Copy link
Contributor

@sadielbartholomew sadielbartholomew commented Jul 9, 2024

Change Summary

Hi, this afternoon I have been getting familiar with this library using your documentation relating to a work summit I am attending this week. I noticed when working through the basic code overview in the README that the cat_subset reduced object is reported from its representation output as having the same number of datasets and assets as the original cat, which seems misleading, so I have suggested here to replace it with the output I see when running this locally, namely with less datasets and assets after the subset operation.

Related issue number

Trivial docs one-liner change hence I have not raised an Issue first.

Checklist

  • [n/a] Unit tests for the changes exist
  • [n/a] Tests pass on CI
  • [n/a] Documentation reflects the changes where applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant