Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migtd: abstract vmcall operations into VmcallService #198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

migtd: abstract vmcall operations into VmcallService #198

wants to merge 2 commits into from

Commits on Mar 26, 2024

  1. migtd: expose the data slice of VmcallServiceResponse 

    Consumer of this structure may have the requirement to read the data
in slice rather than deserializing bytes into struct directly with
`read_data()` method.

Signed-off-by: Jiaqi Gao <[email protected]>
    @gaojiaqi7
    gaojiaqi7 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d192dff View commit details
    Browse the repository at this point in the history

  2. migtd: abstract vmcall operations into VmcallService 

    There are several duplicate code blocks for setting up buffers,
executing and parsing return values for `TDVMCALL<Service>`.

Here the vmcall operations are abstracted into a struct `VmcallService`
to eliminite the duplicate code.

Signed-off-by: Jiaqi Gao <[email protected]>
    @gaojiaqi7
    gaojiaqi7 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    0a9b33d View commit details
    Browse the repository at this point in the history