Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading and success indicator for registration backend checks #9590

Closed
Tracked by #9315
rebecca-shoptaw opened this issue Jul 19, 2024 · 0 comments · Fixed by #9593
Closed
Tracked by #9315

Add loading and success indicator for registration backend checks #9590

rebecca-shoptaw opened this issue Jul 19, 2024 · 0 comments · Fixed by #9593
Assignees
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] registration Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]

Comments

@rebecca-shoptaw
Copy link
Collaborator

rebecca-shoptaw commented Jul 19, 2024

Dependency to epic #7694. Subtask of #9315.

Problem

With all the new realtime validation in the registration form, one thing we are missing is a loading/success indicator for the backend checks (i.e. taken username/email address) -- this is particularly noticeable now that these checks sometimes happen on (debounced) key-up.

Current behavior:

  • The user enters a taken username then moves on to the next field
  • After an awkward pause, an error appears saying that the username is unavailable
  • The user returns to the field and sees the error briefly appear and disappear as they type, ultimately disappearing for good when they enter a non-taken username

Preferred behavior:

  • The user enters a taken username and then moves on to the next field
  • As soon as they click away, a loading spinner appears in the previous input field to indicate that the check is in progress
  • The spinner disappears and an error message shows
  • The user returns to the field and sees the loading spinner appear again each time they make a change to the username, followed by a fresh error message if it is still taken
  • When they enter a non-taken username, the loading spinner briefly appears, then is replaced by a green checkmark

Proposal & Constraints

What is the proposed solution / implementation?

The idea is to use a similar implementation to the password toggle already in the form, rendering a single image in the right side of the email and username inputs and programmatically changing its source (for spinner vs. checkmark) and display properties (to show/hide it). Specifically:

Which suggestions or requirements should be considered for how feature needs to appear or be implemented?

  • We may also need to set an HTML max-length for the username field (and the email field??) to prevent the text from overlapping the image, which should be no problem because the username does have a max length of 20 characters

Related files

create.html
realtime_account_validation.js

Stakeholders

@cdrini


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@rebecca-shoptaw rebecca-shoptaw added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] registration Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jul 19, 2024
@rebecca-shoptaw rebecca-shoptaw self-assigned this Jul 19, 2024
@cdrini cdrini added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Lead labels Jul 22, 2024
@cdrini cdrini removed the Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] registration Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants