-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loading and success indicators for backend checks #9593
Add loading and success indicators for backend checks #9593
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9593 +/- ##
==========================================
+ Coverage 16.06% 17.12% +1.06%
==========================================
Files 90 89 -1
Lines 4769 4752 -17
Branches 832 831 -1
==========================================
+ Hits 766 814 +48
+ Misses 3480 3428 -52
+ Partials 523 510 -13 ☔ View full report in Codecov by Sentry. |
21352b7
to
f7becfc
Compare
f7becfc
to
5dc6b3b
Compare
5dc6b3b
to
2fc53b6
Compare
c87944c
to
1e35380
Compare
1e35380
to
e350230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! On small accessibility feedback. Otherwise, ran through the page and the indicators appeared when expected, and completing the form correctly created the account!
Closes #9590.
Feature. Adds loading and success indicator icons for API requests in registration form, i.e. to check if username/email is available. Avoids awkward pause as checks run and sudden error message appearance/disappearance when validating on key-up.
Technical
Very simple! Ended up just going with two images, both initially rendered
display: none
, and then conditionally shown/hidden via the script inrealtime_account_validation.js
.Changed a few class names around to be able to apply the password icon styling to all three, and to be able to query the correct icons to show/hide.
Testing
/account/create
Screenshot
Stakeholders
@cdrini