Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated apcups to 2.0.0 #3297

Merged
merged 9 commits into from
Feb 24, 2024
Merged

Updated apcups to 2.0.0 #3297

merged 9 commits into from
Feb 24, 2024

Conversation

XHunter74
Copy link
Contributor

  • Changed the minimal version of nodejs to 16
  • Changed the minimal version of "@iobroker/adapter-core" to 3.0.4"

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Feb 11, 2024
@mcm1957 mcm1957 added the (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. label Feb 11, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Feb 11, 2024

@XHunter74

Please consider replacing "private" release workflow with standard iobrokers test-and-release workflow. There seems to be not much a difference, but as you are not using the standard workflow I'll have to check in detail which might delay release a few days.

AND more important:

Please consinder semantiv versioning with next release:
increase patch version if only bug fixes included
increase minor version if nonbreaking changes including nw features are included
increase major version if braking chnages are included.

adding new fileds is for sure no bug fix (1.0.13)
increaing node requiresments is breacking as you write yourself. (1.0.18). Here at least a minor version changes (as this is common praxis for ioBroker) would heve been required.

I do NOT consider this blocking, you do nOT need to create a new release immidiatly (but feel free to do ich you like). I will megre after checking and passing tests anyway - but next time please increase version according to changes included.
Thanks

P.S: If you prefer a PR to update tests let me know.

@mcm1957
Copy link
Collaborator

mcm1957 commented Feb 11, 2024

reminder - 13.02.2024

@XHunter74
Copy link
Contributor Author

Please consider replacing "private" release workflow with standard iobrokers test-and-release workflow. There seems to be not much a difference, but as you are not using the standard workflow I'll have to check in detail which might delay release a few days.

Could you please tell me how I can switch the project to standard test-and-release workflow?

@github-actions github-actions bot added the *📬 a new comment has been added label Feb 12, 2024
@mcm1957 mcm1957 changed the title Updated apcups to 1.0.18 Updated apcups to 2.0.0 Feb 17, 2024
@github-actions github-actions bot deleted a comment from mcm1957 Feb 17, 2024
@mcm1957 mcm1957 removed the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Feb 17, 2024
@XHunter74
Copy link
Contributor Author

XHunter74 commented Feb 17, 2024

I fixed warnings and changed the repository name in io-package.json
from https://raw.githubusercontent.com/xhunter74/...
to https://raw.githubusercontent.com/XHunter74/...
and action has failed.
What do you think I should do in this case?

@mcm1957
Copy link
Collaborator

mcm1957 commented Feb 18, 2024

I fixed warnings and changed the repository name in io-package.json from https://raw.githubusercontent.com/xhunter74/... to https://raw.githubusercontent.com/XHunter74/... and action has failed. What do you think I should do in this case?

This error:
image

is caused by a difference betwenn latest and stable repo - tested against the release versions. I'll clena this up, no action required by you.

@mcm1957
Copy link
Collaborator

mcm1957 commented Feb 18, 2024

RE-CHECK!

@github-actions github-actions bot added the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Feb 18, 2024
Copy link

Automated adapter checker

ioBroker.apcups

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

  • ❗ [E405] Icon (latest) must be in the following path: https://raw.githubusercontent.com/xhunter74/ioBroker.apcups/master/
  • ❗ [E407] Meta URL (latest) must be equal to https://raw.githubusercontent.com/xhunter74/ioBroker.apcups/master/io-package.json
  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W170] "common.keywords" should not contain "iobroker, adapter, smart home" io-package.json
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Adapter releases: https://www.iobroker.dev/adapter/apcups/releases
Adapter statistic: https://www.iobroker.dev/adapter/apcups/statistics

History and usage information for release 2.0.0:

2.0.0 created 17.2.2024 (0 days old)
3 users (0.47%)

1.0.15 (stable) created 25.4.2023 (298 days old)
500 users (stable) (78.99%)

Please verify that this PR really tries to update to release 2.0.0!

ioBroker.philips-air

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

  • ❗ [E605] No actual year found in copyright. Please add "Copyright (c) 2020-2024 bdeluefox [email protected]" at the end of README.md
  • ❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2020-2024 bdeluefox [email protected]" at the start of LICENSE
  • 👀 [W171] "common.title" is deprecated in io-package.json

Adapter releases: https://www.iobroker.dev/adapter/philips-air/releases
Adapter statistic: https://www.iobroker.dev/adapter/philips-air/statistics

History and usage information for release 1.0.3:

1.0.3 created 23.12.2022 (421 days old)
366 users (87.77%)

1.0.3 (stable) created 23.12.2022 (421 days old)
366 users (stable) (87.77%)

Please verify that this PR really tries to update to release 1.0.3!

ioBroker.apcups

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

  • ❗ [E426] Icon (stable) must be in the following path: https://raw.githubusercontent.com/XHunter74/ioBroker.apcups/master/
  • ❗ [E428] Meta URL (stable) must be equal to https://raw.githubusercontent.com/XHunter74/ioBroker.apcups/master/io-package.json
  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W170] "common.keywords" should not contain "iobroker, adapter, smart home" io-package.json
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Adapter releases: https://www.iobroker.dev/adapter/apcups/releases
Adapter statistic: https://www.iobroker.dev/adapter/apcups/statistics

History and usage information for release 2.0.0:

2.0.0 created 17.2.2024 (0 days old)
3 users (0.47%)

1.0.15 (stable) created 25.4.2023 (298 days old)
500 users (stable) (78.99%)

Please verify that this PR really tries to update to release 2.0.0!

Add comment "RE-CHECK!" to start check anew

@mcm1957 mcm1957 removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. *📬 a new comment has been added labels Feb 18, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Feb 18, 2024

I fixed warnings and changed the repository name in io-package.json from https://raw.githubusercontent.com/xhunter74/... to https://raw.githubusercontent.com/XHunter74/... and action has failed. What do you think I should do in this case?

casing changes have been done at stable and latest, so everything is green here again.
Missing "admin" add logo path has been added.

@mcm1957 mcm1957 added the STABLE - brand new This PR for stable has been created before release was available at latest for min 7 days label Feb 18, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Feb 18, 2024

reminder 25,02,2024

@mcm1957
Copy link
Collaborator

mcm1957 commented Feb 18, 2024

Short summary

  • errors from repository tests have been fixed
  • I've created a PR with the standard workflow. Please check before merging. Its only a SUGGESTION - feel free to keep you own tests if you prefer but at least consider renaming the file to test-and.release.yml to make it locateable by autiomatic tests.
  • As v2.0.0 is only 1 day old I will wait some days for this release at latests befor merging into stable

Currently NO actions are required by you.

Thanks

@github-actions github-actions bot added 13.2.2024 ⚠️check Issue/PR needs attention labels Feb 18, 2024
@mcm1957 mcm1957 removed ⚠️check Issue/PR needs attention 13.2.2024 labels Feb 18, 2024
@github-actions github-actions bot added 13.2.2024 ⚠️check Issue/PR needs attention labels Feb 19, 2024
@mcm1957 mcm1957 removed 13.2.2024 ⚠️check Issue/PR needs attention labels Feb 19, 2024
@github-actions github-actions bot added 13.2.2024 ⚠️check Issue/PR needs attention and removed 13.2.2024 labels Feb 19, 2024
@mcm1957 mcm1957 removed the ⚠️check Issue/PR needs attention label Feb 19, 2024
@github-actions github-actions bot added the ⚠️check Issue/PR needs attention label Feb 24, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Feb 24, 2024

RE-CHECK!

@mcm1957 mcm1957 removed ⚠️check Issue/PR needs attention STABLE - brand new This PR for stable has been created before release was available at latest for min 7 days 24.2.2024 labels Feb 24, 2024
@mcm1957 mcm1957 merged commit fa7bf3a into ioBroker:master Feb 24, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias Stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants