-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fcs to 43.8.200 preview.23516.2 #1202
Merged
baronfel
merged 10 commits into
ionide:nightly
from
dawedawe:update_fcs_to_43.8.200-preview.23516.2
Nov 25, 2023
Merged
Update fcs to 43.8.200 preview.23516.2 #1202
baronfel
merged 10 commits into
ionide:nightly
from
dawedawe:update_fcs_to_43.8.200-preview.23516.2
Nov 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
approved these changes
Nov 25, 2023
@@ -87,7 +87,10 @@ jobs: | |||
run: | | |||
# can't do a tool restore here due to an 8.0.100 rc2 bug - this is fixed in GA so can go back to | |||
# dotnet tool restore then. | |||
dotnet tool install paket --version 8.0.0-alpha002 && dotnet tool install fantomas --version 6.2.2 && dotnet paket restore | |||
dotnet tool install paket --version 8.0.0-alpha002 && dotnet tool install fantomas --version 6.2.3 && dotnet paket restore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that GA has released we can probably remove this in favor of the 'normal' tool restore. I can look into that on main though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 7ea80d4
Updated FCS dependency to test F# 6.0 features and added a new method to
RoslynSourceTextFile
to extract code snippets from a file based on a range.🤖 Generated by Copilot at 7ea80d4
📝🆕🌙
WHY
Besides other strange failings it's the same as with #1192 : The tests time out/get stuck at some point. Need to dig into that.
HOW
🤖 Generated by Copilot at 7ea80d4
GetSubTextFromRange
method toRoslynSourceTextFile
type to extract code snippets from a file based on a range of lines and columns (link)