Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fcs to 43.8.200 preview.23516.2 #1202

Merged

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Nov 14, 2023

WHAT

🤖 Generated by Copilot at 7ea80d4

Updated FCS dependency to test F# 6.0 features and added a new method to RoslynSourceTextFile to extract code snippets from a file based on a range.

🤖 Generated by Copilot at 7ea80d4

GetSubTextFromRange
Extracts snippets from files
Useful for edits

📝🆕🌙

WHY

Besides other strange failings it's the same as with #1192 : The tests time out/get stuck at some point. Need to dig into that.

HOW

🤖 Generated by Copilot at 7ea80d4

  • Enable FCS nightly feed source and use newer preview version of FCS package to test new F# 6.0 features and fixes (link, link)
  • Add GetSubTextFromRange method to RoslynSourceTextFile type to extract code snippets from a file based on a range of lines and columns (link)

@@ -87,7 +87,10 @@ jobs:
run: |
# can't do a tool restore here due to an 8.0.100 rc2 bug - this is fixed in GA so can go back to
# dotnet tool restore then.
dotnet tool install paket --version 8.0.0-alpha002 && dotnet tool install fantomas --version 6.2.2 && dotnet paket restore
dotnet tool install paket --version 8.0.0-alpha002 && dotnet tool install fantomas --version 6.2.3 && dotnet paket restore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that GA has released we can probably remove this in favor of the 'normal' tool restore. I can look into that on main though.

@baronfel baronfel merged commit b7ce37d into ionide:nightly Nov 25, 2023
12 checks passed
@dawedawe dawedawe deleted the update_fcs_to_43.8.200-preview.23516.2 branch November 26, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants