Add balance sheet report #734
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello & Welcome! :)
Thanks for taking the time to help improve ITFlow. We're excited to review your contributions - we'll review this PR as soon as we can!
Whilst you're waiting, please feel free to check out the forum.
Just so you know, all contributions to ITFlow are licensed under the GNU GPL. By contributing you grant us a perpetual & irrevocable license to include your work in ITFlow.
|
Test these changes at: https://balancesheet734.pr-review.itflow.org |
report_balance_sheet.php
Outdated
| echo " | ||
| <tr> | ||
| <td>$account_type_string</td> | ||
| <td><a class=\"text-dark\" href=\"account_details.php?account_name=$account_name_encoded\">{$accountRow['account_name']}</a></td> |
There was a problem hiding this comment.
-
All non-int variables should be echoed/assigned using nullable_htmlentities to prevent XSS
-
Ideally (where possible) we try to assign the variable once (e.g. as $account_type and $account_name and then just re-use as required), rather than constantly reusing $accountRow['account_type'] - its much cleaner
There was a problem hiding this comment.
This has been resolved. Looking over the rest of the code now.
|
Heyy @o-psi! Thanks for the PR :) I've made a few suggestions, but will leave the rest to Johnny. I know he's quite busy recently with client projects though so it may be a few days before he has chance to take a look. |
|
@wrongecho @johnnyq I believe this PR is ready to ship. If we can do one of those fancy test deployments to test from clean. |
|
Test these changes at: https://balancesheet734.pr-review.itflow.org |
Wellllll... Seems I didn't really account for PRs with different database changes with the same version number. I thought a close and reopen would start it fresh but seems not - even with a manual webhook redelivery for the PR Open event :/ |
|
@wrongecho It seems like you didnt account for bozos like me to be messing with your DevOps hahah. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
This one looks exciting @o-psi Good work and my accountant will be happy, It looks like it may be ready any discrepancies @o-psi and @wrongecho |
|
I am having a meeting with my accountant today to see if she needs or wants anything else for this PR, and to ensure it is all working according to accrual basis accounting. I also wanted to ask @johnnyq if there was any reason there is not an account balance field in the DB. Each time its calculated in the frontend, it should be logged and recorded in the DB. This may be a post 1.0 feature. |
I love the idea of the account_balance being in the db. This makes sense so PHP doesn't have to do so much leg work, we just didn't think of it at the time, So I'm totally for it |
|
im going to merge this in for now |
|
I made some code changes after merging this PR and something still isn't right with the calculations |
Summary:
This PR brings several key updates to the IT Flow project, including the introduction of a Balance Sheet report and enhancements to account management.
Changes:
Balance Sheet Report: Introduced a new screen for balance sheet reports. This report is also accessible via the side navigation (report_balance_sheet.php).
Account Types: Added a dropdown for selecting account types (Current Assets, Fixed Assets, etc.) in the add and edit account modals (account_add_modal.php and account_edit_modal.php).
Updated Accounts Screen: Accounts now display their associated types (accounts.php).
New Account Types: Accounts now have an Account Type, and account types are editable in the settings.
Database Updates:
Added a new account_type field to the accounts table.
Database version incremented to 0.8.7.
Code Refactoring: Added comments for better code readability and future development.
Other Backend Changes:
Updated post/account.php to accommodate the new account_type field.