Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add balance sheet report #734
Add balance sheet report #734
Changes from 9 commits
9551399
ccb67d8
db5eee0
bc95bb4
29e2e5e
844a85c
f8bc2ee
5d964c9
3a87908
d63da07
3e96751
6a485a9
1455e20
2ee87f0
f190e10
8b6c909
749281a
81f34e2
03c8f47
69272a8
a8e03d4
3ef045e
72da87e
e4fc7bc
31043da
aef4ec0
d5e03f1
9c099f7
bb559a4
4fbf448
96e493d
7b772cf
22a072f
74e2866
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All non-int variables should be echoed/assigned using nullable_htmlentities to prevent XSS
Ideally (where possible) we try to assign the variable once (e.g. as $account_type and $account_name and then just re-use as required), rather than constantly reusing $accountRow['account_type'] - its much cleaner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been resolved. Looking over the rest of the code now.