Skip to content

Commit

Permalink
Update manualdrops to allow to specify serum_replicates to exclude (#50)
Browse files Browse the repository at this point in the history
* update process_plate to fix bug in specifying serum_replicates to exclude

* update changelog

* update changelog corrected link

* fix version on Changelog

* add change for barcode_serum_replicates as well
  • Loading branch information
anloes authored Sep 12, 2024
1 parent 7bcb1c7 commit bbe741c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# CHANGELOG

#### version 3.1.2
- Minor bug fix to resolve issue with specifying serum_replicates and barcode_serum_replicates to manual drops, similar issue resolved in 3.1.1. Addresses [this issue](https://github.com/jbloomlab/seqneut-pipeline/issues/49).

#### version 3.1.1
- Minor bug fix to make it possible to add `wells` or `barcodes` to the `manual_drops` specified for each plate. Addresses [this issue](https://github.com/jbloomlab/neutcurve/issues/45).
- Minor bug fix to make it possible to add `wells` or `barcodes` to the `manual_drops` specified for each plate. Addresses [this issue](https://github.com/jbloomlab/seqneut-pipeline/issues/45).

### version 3.1.0
- Configured to enable plate-level indices to be embedded in the round-1 PCR primers (see [this issue](https://github.com/jbloomlab/seqneut-pipeline/issues/40)). Essentially, this amounts to allowing a per-plate flanking sequence to be specified for each plate, and only FASTQ reads with that flanking sequence are read for that plate. Typically this index would be specified as `upstream2` in the [illuminabarcodeparser](https://jbloomlab.github.io/dms_variants/dms_variants.illuminabarcodeparser.html). To enable this change, altered the configuration from the previous setup of just having a single global `illumina_barcode_parser_params` applied to all plates. Now such a global parser is still specified that has default values that you want to apply to all plates. But in addition, in the per-plate configuration you can specify `illumina_barcode_parser_params` that are added to (and override) anything in the global parser params, and can contain plate specific `upstream2` and other relevant setting (eg, `upstream2_mismatch`). The test example was modified to use this option for plate2 and plate11.
Expand Down
6 changes: 5 additions & 1 deletion notebooks/process_plate.py.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,10 @@
" counts = counts[~counts[\"well\"].isin(qc_drops[filter_type])]\n",
" elif filter_type == \"barcodes\":\n",
" counts = counts[~counts[\"barcode\"].isin(qc_drops[filter_type])]\n",
" elif filter_type == \"serum_replicates\":\n",
" counts = counts[~counts[\"serum_replicate\"].isin(qc_drops[filter_type])]\n",
" elif filter_type == \"barcode_serum_replicates\":\n",
" counts = counts[~counts[\"barcode_serum_replicate\"].isin(qc_drops[filter_type])]\n",
" else:\n",
" assert filter_type in set(counts.columns)\n",
" counts = counts[~counts[filter_type].isin(qc_drops[filter_type])]"
Expand Down Expand Up @@ -1505,7 +1509,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.7"
"version": "3.12.1"
}
},
"nbformat": 4,
Expand Down

0 comments on commit bbe741c

Please sign in to comment.