-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-63770] Make trend charts configurable #124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace previous build and date buttons in chart with a configure button. Fixes https://issues.jenkins.io/browse/JENKINS-63770. Note: requires Bootstrap 5.
uhafner
changed the title
[JENKINS-63770] Make trend charts configurable
[JENKINS-63770] Make zoomable trend chart configurable
Apr 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
============================================
- Coverage 72.97% 64.28% -8.69%
Complexity 5 5
============================================
Files 2 3 +1
Lines 37 42 +5
Branches 3 3
============================================
Hits 27 27
- Misses 10 15 +5
Continue to review full report at Codecov.
|
uhafner
changed the title
[JENKINS-63770] Make zoomable trend chart configurable
[JENKINS-63770] Make trend charts configurable
May 10, 2021
# Conflicts: # pom.xml
Otherwise we would register for events multiple times.
Now the general trend options are changed for *all* charts. So individual trend chart dialogs change the global configuration and the local one.
Now configuration of trend charts in job page and trend charts in details pages use a different dialog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace previous build and date buttons inside of the chart with a configure button that provides a configuration of
The selected configuration values will be saved in a browser's local storage.
Fixes JENKINS-63770.
Tasks:
Open points that need to be addressed in subsequent PRs:
Screenshots
Trend chart with data-zoom in plugin view
Build trend chart in jobs
overview