Make trend charts configurable (with Bootstrap 5) #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
============================================
- Coverage 79.79% 79.57% -0.22%
- Complexity 1425 1427 +2
============================================
Files 238 238
Lines 5271 5283 +12
Branches 411 414 +3
============================================
- Hits 4206 4204 -2
- Misses 911 925 +14
Partials 154 154
Continue to review full report at Codecov.
|
# Conflicts: # plugin/pom.xml
# Conflicts: # plugin/pom.xml
Now the general trend options are changed for *all* charts. So individual trend chart dialogs change the global configuration and the local one.
Now configuration of trend charts in job page and trend charts in details pages use a different dialog.
Now configuration of trend charts in job page and trend charts in details pages use a different dialog.
uhafner
changed the title
This was referenced Jun 4, 2021
# Conflicts: # plugin/pom.xml
| @@ -1,5 +1,11 @@ | |||
| /* global jQuery3, view, echartsJenkinsApi */ | |||
| /* global jQuery3, view, echartsJenkinsApi, bootstrap5, trendDefaultStorageId */ | |||
There was a problem hiding this comment.
trendDefaultStorageId doesn't seem to be referenced elsewhere.
There was a problem hiding this comment.
I was searching for "storage" because it was not clear to me whether the configuration is stored in the browser, in the Jenkins job, or in the Jenkins user profile.
There was a problem hiding this comment.
Currently the configuration is stored in the Browser local storage only. If required this can be changed later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework UI components to use the upcoming Bootstrap 5 release.
Make build trend charts configurable:
Downstream of jenkinsci/echarts-api-plugin#124