[JENKINS-5347] Added use commit times on files #116

ekesseler · 2015-06-08T11:51:47Z

http://issues.jenkins-ci.org/browse/JENKINS-5347

Applied your change requests from: https://github.com/jenkinsci/subversion-plugin/pull/64/files

Please approve and add this to the next version or give me feedback.

Thank you

jenkinsadmin · 2015-06-08T12:02:53Z

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

ekesseler · 2015-06-08T12:13:29Z

Seems like the checkout failed (timeout) during the test

ekesseler · 2015-06-15T06:49:48Z

The test failing (timeout) had nothing to do with the commit.

christ66 · 2015-07-02T08:42:48Z

@dvlemplek Can you re-base your pull request. The tests that are failing were fixed.

ekesseler · 2015-07-02T09:11:57Z

Other tests failing, had nothing to do with the commit.

oleg-nenashev · 2015-07-04T20:31:53Z

src/main/java/hudson/scm/SubversionSCM.java

-     * Gets the file that stores the revision.
-     */
-    @Deprecated
-    public static File getRevisionFile(AbstractBuild build) {


This change is unrelated to the pull request title.
IMO it should be reverted, because it breaks the backward compatibility.

oleg-nenashev · 2015-07-04T20:34:31Z

The most of the pull requests looks good to me. If the backward compatibility issue gets fixed, I would vote for merging it

ekesseler · 2015-07-06T07:05:09Z

You would have to tell me the JIRA ISSUE, since I don't have access to it.

oleg-nenashev · 2015-07-06T07:06:51Z

http://issues.jenkins-ci.org/browse/JENKINS-5347
The entire JENKINS project in JIRA is public, hence you should have an access

tomap · 2015-07-09T10:17:14Z

Hi,

I have the same need. Would be glad to see this pull request merged.

Thank you

oleg-nenashev · 2015-07-09T10:37:37Z

src/main/resources/hudson/scm/SubversionSCM/config.jelly

@@ -56,5 +56,8 @@ THE SOFTWARE.
    <f:entry title="${%Filter changelog}" field="filterChangelog">
        <f:checkbox />
    </f:entry>
+    <f:entry title="${%Set check out file dates to the 'last commit time'}" field="usingCommitTimes">
+	<f:checkbox />


tabs in this line

Not fixed, but it's up o the plugin's maintainer

It should be fixed.

Should be fixed now.

oleg-nenashev · 2015-07-09T10:39:58Z

@dvlemplek
👍 for the PR when a minor comment gets fixed.
BTW, the commits should be squashed into a single one

recena · 2015-08-06T10:15:56Z

@dvlemplek Do you plan to review @oleg-nenashev 's comments?

ekesseler · 2015-08-07T07:03:09Z

@oleg-nenashev I thought I already did: ekesseler@c13f6f5

ekesseler · 2015-08-13T07:46:10Z

Please let me know if something is missing, I don't see it at the moment.

recena · 2015-08-13T08:55:39Z

src/test/java/hudson/scm/SubversionSCMTest.java

+        FreeStyleProject p = createFreeStyleProject();
+        File repo = new CopyExisting(getClass().getResource("small.zip")).allocate();
+        SubversionSCM scm = new SubversionSCM(ModuleLocation.parse(new String[]{"file://" + repo.toURI().toURL().getPath()},
+          new String[]{"."},null,null), new UpdateUpdater(), null, "/z.*", "", "", "", "", false, false, null, false);


Please, add spaces after the params.

recena · 2015-08-13T08:58:14Z

@dvlemplek I'd like to make a smoke test before to merge this. I'll back here this night.

recena · 2015-08-13T09:00:32Z

@dvlemplek If you are working on JENKINS-5347, please accept the issue and update its status (in progress).

ekesseler · 2015-08-17T08:11:30Z

Should be all done now?

oleg-nenashev · 2015-08-17T08:24:35Z

👍

recena · 2015-08-17T08:42:39Z

src/main/resources/hudson/scm/SubversionSCM/help-usingCommitTimes.html

@@ -0,0 +1,8 @@
+<div>
+  If set Jenkins will set the file timestamps to the last commit time (of each file) when doing a checkout or an update. Otherwise Jenkins will set the current date as the timestamp of each file.


This sentence should be a paragraph, please use <p>.

recena · 2015-08-17T08:44:27Z

@dvlemplek As @oleg-nenashev said, the commits should be squashed into a single one

recena · 2015-08-17T16:38:20Z

@dvlemplek We plan to cut a release (revision) at the end of this week. I hope to include your PR.

ekesseler · 2016-01-08T08:09:43Z

How is the status on this? The build failed because of unrelated timeouts, can you trigger it again and include the pull request?

recena · 2016-01-08T09:05:53Z

@dvlemplek I'll try to review it as soon as possible.

recena · 2016-01-08T17:31:54Z

src/test/java/hudson/scm/SubversionSCMTest.java

+    }
+
+    /**
+     * Test related to https://issues.jenkins-ci.org/browse/JENKINS-5347


Please, use the annotation @Issue

…otation

ekesseler · 2016-01-11T09:57:22Z

Merged upstream and fixed your comments.

recena · 2016-01-11T10:00:11Z

@dvlemplek Great!

christ66 · 2016-01-11T20:20:31Z

LGTM

unitychrism · 2016-01-12T03:41:34Z

This is working as expected with a built version of the plugin on my end, thanks for the re-focus :-)

unitychrism · 2016-02-25T23:10:36Z

Any hope of a merge anytime soon?

kennetn · 2016-08-22T06:43:24Z

Any news on this ?

DaveNoth · 2016-09-08T01:32:53Z

You do fantastic work with this plugin so I understand if we can get it in soon. If there is anyway, please consider it. We would love this fix.

oleg-nenashev

LGTM, may have merge conflicts

jglick · 2017-06-16T14:40:09Z

Not accepting new features at this time unless obviously self-contained. (Also would need to use @DataBoundSetter.)

oleg-nenashev · 2017-10-31T09:04:16Z

merge conflict

ekesseler mentioned this pull request Jun 15, 2015

Add commit times support #115

Closed

oleg-nenashev reviewed Jul 4, 2015
View reviewed changes

oleg-nenashev reviewed Jul 9, 2015
View reviewed changes

recena reviewed Aug 13, 2015
View reviewed changes

recena changed the title ~~JENKINS-5347 Fixed - Added use commit times on files~~ [JENKINS-5347] Added use commit times on files Aug 13, 2015

recena mentioned this pull request Aug 17, 2015

JENKINS-5347 Fixed - Added use commit times on files #64

Closed

recena reviewed Aug 17, 2015
View reviewed changes

JENKINS-5347 Fixed - Added use commit times on files

416efef

ekesseler force-pushed the add-commit-times-support branch from 08523ac to 416efef Compare August 17, 2015 10:30

recena reviewed Jan 8, 2016
View reviewed changes

ekesseler added 2 commits January 11, 2016 09:57

Merge branch 'master' into add-commit-times-support

5c11806

JENKINS-5347 Fixed - Added use commit times on files - use @issue Ann…

d91475a

…otation

oleg-nenashev approved these changes Jun 16, 2017

View reviewed changes

oleg-nenashev added the ready-to-go label Jun 23, 2017

oleg-nenashev added the merge-conflict label Oct 31, 2017

jglick removed the ready-to-go label Dec 17, 2019

		@@ -0,0 +1,8 @@
		<div>
		If set Jenkins will set the file timestamps to the last commit time (of each file) when doing a checkout or an update. Otherwise Jenkins will set the current date as the timestamp of each file.

[JENKINS-5347] Added use commit times on files #116

Are you sure you want to change the base?

[JENKINS-5347] Added use commit times on files #116

Conversation

ekesseler commented Jun 8, 2015

jenkinsadmin commented Jun 8, 2015

ekesseler commented Jun 8, 2015

ekesseler commented Jun 15, 2015

christ66 commented Jul 2, 2015

ekesseler commented Jul 2, 2015

Choose a reason for hiding this comment

oleg-nenashev commented Jul 4, 2015

ekesseler commented Jul 6, 2015

oleg-nenashev commented Jul 6, 2015

tomap commented Jul 9, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oleg-nenashev commented Jul 9, 2015

recena commented Aug 6, 2015

ekesseler commented Aug 7, 2015

ekesseler commented Aug 13, 2015

Choose a reason for hiding this comment

recena commented Aug 13, 2015

recena commented Aug 13, 2015

ekesseler commented Aug 17, 2015

oleg-nenashev commented Aug 17, 2015

Choose a reason for hiding this comment

recena commented Aug 17, 2015

recena commented Aug 17, 2015

ekesseler commented Jan 8, 2016

recena commented Jan 8, 2016

Choose a reason for hiding this comment

ekesseler commented Jan 11, 2016

recena commented Jan 11, 2016

christ66 commented Jan 11, 2016

unitychrism commented Jan 12, 2016

unitychrism commented Feb 25, 2016

kennetn commented Aug 22, 2016

DaveNoth commented Sep 8, 2016

oleg-nenashev left a comment

Choose a reason for hiding this comment

jglick commented Jun 16, 2017

oleg-nenashev commented Oct 31, 2017