[JENKINS-14155]Use the lastest changed tag as default #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
|
Closed and Open to relaunch CI |
kuisathaverat
changed the title
Wadeck
reviewed
May 8, 2018
| } | ||
|
|
||
| @DataBoundConstructor | ||
| public ListSubversionTagsParameterDefinition(String name, String tagsDir, String credentialsId, String tagsFilter, String defaultValue, String maxTags, boolean reverseByDate, boolean reverseByName) { | ||
| public ListSubversionTagsParameterDefinition(String name, String tagsDir, String credentialsId, String tagsFilter, String defaultValue, boolean useLatestTag, String maxTags, boolean reverseByDate, boolean reverseByName) { |
There was a problem hiding this comment.
I dunno exactly the guideline for this plugin, but from my PoV it's better to use @DataBoundSetter when you add field instead of putting that in the constructor.
| private final String maxTags; | ||
| private static final String SVN_BRANCHES = "branches"; | ||
| private static final String SVN_TAGS = "tags"; | ||
| private static final String SVN_TRUNK = "trunk"; | ||
|
|
||
| @Deprecated | ||
| public ListSubversionTagsParameterDefinition(String name, String tagsDir, String tagsFilter, String defaultValue, String maxTags, boolean reverseByDate, boolean reverseByName, String uuid) { | ||
| this(name, tagsDir, null, tagsFilter, defaultValue, maxTags, reverseByDate, reverseByName); | ||
| public ListSubversionTagsParameterDefinition(String name, String tagsDir, String tagsFilter, String defaultValue, boolean useLatestTag, String maxTags, boolean reverseByDate, boolean reverseByName, String uuid) { |
There was a problem hiding this comment.
Those additions will result in breaking the binary compatibility. Is it required to pass by the constructor ? I think a simple use of a setter / putting a default value would be sufficient.
| @@ -173,6 +181,10 @@ public DescriptorImpl getDescriptor() { | |||
| return (DescriptorImpl) super.getDescriptor(); | |||
| } | |||
|
|
|||
| @Nonnull public List<String> getTags(@Nullable Job context) { | |||
| return getTags(context, "", isReverseByDate()); | |||
| } | |||
There was a problem hiding this comment.
👍 to think about compatibility
dwnusbaum
reviewed
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent commit (5012326 - [JENKINS-14155] Automatically select the first option of tags listing…"), support was added to select the latest changed tag as default value. For this to work, the repository URL (of the subversion tag parameters) must point to the tags directory (e.g. foo/tags). If you want to also include trunk and branches (i.e. setting the repository URL to foo/), you cannot benefit from the "use the latest tag" feature.
This branch extends the recent functionality, such that one can use a repository URL pointing to the top level directory (foo) while still using the latest changed tag from the tags sub directory as default.
To this end a new checkbox "Use latest tag" is added below the "Default value" text box.