Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jetty.jsonnet #30

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Update jetty.jsonnet #30

merged 1 commit into from
Nov 7, 2023

Conversation

jmcc0nn3ll
Copy link
Contributor

rename the jetty.test.policy repo to jetty-test-policy to test some things

rename the jetty.test.policy repo to jetty-test-policy to test some things

Signed-off-by: Jesse McConnell <[email protected]>
@jmcc0nn3ll jmcc0nn3ll requested review from a team as code owners November 7, 2023 14:50
Copy link

github-actions bot commented Nov 7, 2023

Diff for 93d599f:
Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization jetty[id=jetty]

  
!   repository[name="jetty.test.policy"] {
!     name                                                     = "jetty.test.policy" -> "jetty-test-policy"
!   }
  
  Plan: 0 to add, 1 to change, 0 to delete.
Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Organization jetty[id=jetty]
--- original
+++ canonical
@@ -14,6 +14,7 @@
       }
     }
     orgs.newRepo('jetty-test-policy') {
+      aliases: ["jetty.test.policy"]
       allow_merge_commit: true
       allow_update_branch: false
       archived: true

@@ -310,7 +310,8 @@ orgs.newOrg('jetty') {
actions_can_approve_pull_request_reviews: false,
},
},
orgs.newRepo('jetty.test.policy') {
orgs.newRepo('jetty-test-policy') {
aliases: ["jetty.test.policy"],
Copy link
Contributor

@joakime joakime Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this aliases entry something we have to keep permanently in the jetty.jsonnet now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering that as well, for example if we moved i-jetty over from jetty-project and then decided to rename it in the jetty org, would that disrupt follows and things. Or is the alias something that protects that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be removed after the renaming has happened, however it might serve as some kind of history, i.e. what names did have this repo in the past.

@jmcc0nn3ll
Copy link
Contributor Author

When does this take action? The repo was archived and I was wondering if that was an issue'

@netomi netomi merged commit f8e3c36 into jetty:main Nov 7, 2023
1 check passed
@netomi
Copy link
Contributor

netomi commented Nov 7, 2023

indeed renaming an archived repo is not possible, I did unarchive it and then apply, changes are now live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants