Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jetty.jsonnet #30

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Update jetty.jsonnet #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion otterdog/jetty.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,8 @@ orgs.newOrg('jetty') {
actions_can_approve_pull_request_reviews: false,
},
},
orgs.newRepo('jetty.test.policy') {
orgs.newRepo('jetty-test-policy') {
aliases: ["jetty.test.policy"],
Copy link
Contributor

@joakime joakime Nov 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this aliases entry something we have to keep permanently in the jetty.jsonnet now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering that as well, for example if we moved i-jetty over from jetty-project and then decided to rename it in the jetty org, would that disrupt follows and things. Or is the alias something that protects that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be removed after the renaming has happened, however it might serve as some kind of history, i.e. what names did have this repo in the past.

archived: true,
allow_merge_commit: true,
allow_update_branch: false,
Expand Down