-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor commands output formats #96
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Jul 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Jul 10, 2024
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 1, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 1, 2024
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 7, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 7, 2024
6 tasks
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.Move all
Results
and outputs to their inner package, organize currently available code and renames to fit better.Before:
After:
Move detection out of SCA to run first thing in audit
jfrog-apps-config
.Change
Results
object toScanCommandResults
Separate converting
ScanCommandResults
to different output formats and printing the output.output
package - Write the results in a specific format as an output string.conversion
package - Parse theScanCommandResults
object to convert it to different formats that we are supporting.Make implementing a new output format (by introducing an interface) easier, and maintain the currently supported.
General validation improvments for results structs