Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #423 - doc dev and test setup #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clach04
Copy link
Contributor

@clach04 clach04 commented Dec 12, 2022

No description provided.

Copy link
Owner

@jmathai jmathai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind making the change to the Readme and requirements.txt?

Install requirements similar to installing as a user and then run tests. NOTE different requirement file(s):

```
python -m pip install -r elodie/tests/requirements.txt
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An improvement here would probably be to reference dependent requirements from here and just install from a single requirements.txt file.

-r ../../requirements.txt
-r ../plugins/googlephotos/requirements.txt

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looks like the first line is already in there. Just need the latter.

Then this line can also be deleted.
https://github.com/jmathai/elodie/blob/master/.circleci/config.yml#L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants