Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #423 - doc dev and test setup #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue #423 - doc dev and test setup #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,16 @@ cp config.ini-sample ~/.elodie/config.ini

If you're an english speaker then you will probably want to add `prefer_english_names=True` to the `[MapQuest]` section else you'll have cities named using the local language.

## Developing

Install requirements similar to installing as a user and then run tests. NOTE different requirement file(s):

```
python -m pip install -r elodie/tests/requirements.txt
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An improvement here would probably be to reference dependent requirements from here and just install from a single requirements.txt file.

-r ../../requirements.txt
-r ../plugins/googlephotos/requirements.txt

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looks like the first line is already in there. Just need the latter.

Then this line can also be deleted.
https://github.com/jmathai/elodie/blob/master/.circleci/config.yml#L15

python -m pip install -r elodie/plugins/googlephotos/requirements.txt
python elodie/tests/run_tests.py
```

## Questions, comments or concerns?

The best ways to provide feedback is by opening a [GitHub issue](https://github.com/jmathai/elodie/issues) or emailing me at [[email protected]](mailto:[email protected]).