Add logger to seeder. #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem Seeder had no logger. Uses print statements in exceptions. Solution - Added logger to `seed_database.py` - Modified `Dockerfile.seed` to copy API logger config - Updated exceptions to send errors to logger instead of print Ticket URL https://mediform.atlassian.net/browse/MEDI-39 Documentation N/A Tests Run - Built and run seeder using `docker compose up --build seeder`
MadelaineJ
reviewed
Feb 1, 2024
| @@ -83,7 +93,7 @@ def create_user(user: Dict, db: Session) -> User: | |||
| print(e) | |||
| db.rollback() | |||
| db.flush() | |||
| print(f"User {user_obj.email} already exists") | |||
| logger.error("Error adding user to database.", exc_info=True) | |||
There was a problem hiding this comment.
why is this changed to not specify the error?
There was a problem hiding this comment.
Above that:
project-ct/app/api/seeder/seed_database.py
Lines 72 to 76 in 2163dbe
It already checks if the user exists, so the error is probably something else that the stack trace will reveal using exc_info=True.
| @@ -176,8 +186,7 @@ def seed_database(): | |||
| print(e) | |||
| db.rollback() | |||
| db.flush() | |||
| print(f"ERROR creating patient encounter: {patient_encounter}") | |||
| print(f"\tERROR: {e}") | |||
| logger.error(f"Error adding patient encounter to db.", exc_info=True) | |||
MadelaineJ
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Seeder had no logger. Uses print statements in exceptions.
Solution
seed_database.pyDockerfile.seedto copy API logger configTicket URL
https://mediform.atlassian.net/browse/MEDI-39
Documentation
N/A
Tests Run
docker compose up --build seeder