-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logger to seeder. #82
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,9 @@ | |
from typing import List, Dict | ||
import faker | ||
from datetime import datetime, timedelta | ||
import logging | ||
import logging.config | ||
import yaml | ||
|
||
from sqlalchemy.orm import Session | ||
from fastapi.testclient import TestClient | ||
|
@@ -16,6 +19,13 @@ | |
|
||
fake = faker.Faker() | ||
|
||
# Load logger configuration | ||
with open("api/logger_config.yaml", "r") as f: | ||
log_cfg = yaml.safe_load(f) | ||
logging.config.dictConfig(log_cfg) | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
def create_authed_client(email: str, password: str, client: TestClient): | ||
"""Create an authenticated client for testing | ||
|
@@ -83,7 +93,7 @@ def create_user(user: Dict, db: Session) -> User: | |
print(e) | ||
db.rollback() | ||
db.flush() | ||
print(f"User {user_obj.email} already exists") | ||
logger.error("Error adding user to database.", exc_info=True) | ||
return user_obj | ||
|
||
|
||
|
@@ -176,8 +186,7 @@ def seed_database(): | |
print(e) | ||
db.rollback() | ||
db.flush() | ||
print(f"ERROR creating patient encounter: {patient_encounter}") | ||
print(f"\tERROR: {e}") | ||
logger.error(f"Error adding patient encounter to db.", exc_info=True) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Stack trace? |
||
|
||
print(f"Created {counter} patient encounters for 2023 festival") | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this changed to not specify the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above that:
project-ct/app/api/seeder/seed_database.py
Lines 72 to 76 in 2163dbe
It already checks if the user exists, so the error is probably something else that the stack trace will reveal using exc_info=True.