Windows 3.1 style for configuration tool #5108
Conversation
As explained, this will need more work, not sure how these as there's no way as far as I know on checking whether an iterator is null or not.
|
By the way, not sure about that one nor when it started to happen: |
|
Nice work! Here's an example of an actual Windows 3.1 application using the "3D" common controls DLL for color reference for future development. |
|
I wonder if we can make the buttons slightly thinner so that the
|
|
Either the configuration menu should enforce a minimum of 800x600, or perhaps all the buttons could be placed inside a scrollable region. |
|
Seems to set However on Linux, you can use the space used for the menu bar, so you have enough space with the default window size without changing the settings.
|
I've got a VM up and been using Paint.NET to grab every detail as I can! |
1st thing I guess would be to remove the header "Choose a settings...", it takes place and is useless. Then to see where the checkbox could go, maybe it can work in menu or in other windows. If so, then we gain 1 line immediately. Also maybe, window can become 720 px wide with maybe slightly smaller labels, e.g. IDE #1, LPT, COM. If all these work we might be able to have 5 columns and would gain lot of space for eventual future sections. |
Problem is, if below 26 then focus while pressed is cropped... And if you adjust label positions it looks really squished. Then you have margins between buttons that must be kept else it looks horrible. Noticed that, not sure why on default config with TTF save/close are not cropped:
|
|
Hmm, so it's kind of complicated. |
It fits EXACTLY, there's zero pixel room at bottom.
|
Before:
After:
Before:
After:
Summary:
I think that's enough for the PR... Reference for future improvements:
|
|
Final version:
Fixed layout, sorted help/properties, revamped main window/labels. Mouse wheel does not work, it needs window to be clicked at least once for it to work, not sure why: Dark theme: Not for now, not easy at all to come up with the right colors... Full Windows 3.1 theme: Not for now, I did however extract all themes from CONTROL.INI, will need quite some refactoring. Beside mouse wheel issue, things look good, I guess it's enough for this PR. |
| @@ -2272,25 +2333,27 @@ bool ScreenSDL::event(SDL_Event &event) { | |||
| } | |||
| lastdown = 0; | |||
| return rc; | |||
| } | |||
| case SDL_MOUSEWHEEL: | |||
There was a problem hiding this comment.
SDL_MOUSEWHEEL not available on SDL1?
Maybe add #if defined(C_SDL2)
gui_tk.cpp:2336:10: error: use of undeclared identifier 'SDL_MOUSEWHEEL'
case SDL_MOUSEWHEEL:
^
gui_tk.cpp:2337:33: error: no member named 'wheel' in 'SDL_Event'
return mouseWheel(event.wheel.y);
src/libs/gui_tk/gui_tk.cpp
Outdated
| bool WindowInWindow::mouseWheel(int wheel) | ||
| { | ||
| // BUG requires to click at least once in window for it to work | ||
| scroll_pos_y = min(max(scroll_pos_y - wheel * 15, 0), scroll_pos_h); |
There was a problem hiding this comment.
Add #include <algorithm> header, and use std::min, std::max instead?
gui_tk.cpp:2880:20: error: use of undeclared identifier 'min'; did you mean 'fmin'?
scroll_pos_y = min(max(scroll_pos_y - wheel * 15, 0), scroll_pos_h);
^~~
fmin
|
Ready? |
|
Thank you for the fix. I'm happy that the cropped window is fixed as well as the improved look & feel. |
|
Nice! Just two things I'm not happy with: This is really a dirty fix I did by just swapping the operands, it happens during ENC obviously so I am wondering whether it's simply due to it or not, searched online but didn't find much about it: Seems like the GUI would need good refactoring to implement mouse wheel without clicking it first, correct? (btw, just noticed that one can flick scroll, obviously, it's been clicked at this point so that doesn't help much) |
Does this PR introduce new feature(s)?
Trying to apply pixel-perfect Windows 3.11 look'n'feel to CFGTOOL...
Buttons are up as well as their focus style.
Ideally,
Before:
After: