Pass output dimensions to Direct3D shaders #5161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR passes the final output dimensions of the image to shaders, allowing for shaders to adjust scaling parameters automatically when needed.
What issue(s) does this PR address?
None.
Does this PR introduce new feature(s)?
Yes, it adds an OUTPUTDIMS parameter to the D3D scaling effect, which contains the final (after all scaling has been performed) dimensions of the image.
Does this PR introduce any breaking change(s)?
No, existing shaders should function identically to before.
Additional information
Added this primarily so that a sharp-bilinear shader is feasible on Direct3D.