[MRG] fix GUI MPI test #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…un_simulation_mpi Previously this test was passing with an empty dipole list. It was not checking any dipoles were actually created.
-The test fixture network was not working with MPI. Presumably because the smaller network used in the fixture was not compatible with the multiprocessing subprocess call. -We were encountering an error at the h.finitialize step of network_builder > _simulate_single_trial when using the fixture network. The error was within neuron: "NEURON: mindelay is 0 (or less than dt for fixed step method)".
|
@dylansdaniels @ntolley @jasmainak |
dylansdaniels
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
test_gui_run_simulation_mpi. The test was not actually testing if any dipoles were constructed.h.finitializestep ofnetwork_builder>_simulate_single_trialwhen using the fixture network. The error was within neuron: "NEURON: mindelay is 0 (or less than dt for fixed step method)".