Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] fix GUI MPI test #868

Merged
merged 2 commits into from
Aug 27, 2024
Merged

[MRG] fix GUI MPI test #868

merged 2 commits into from
Aug 27, 2024

Commits on Aug 21, 2024

  1. test: added assertion that the dipole list is not empty in test_gui_r… 

    …un_simulation_mpi

Previously this test was passing with an empty dipole list. It was not checking any dipoles were actually created.
    @gtdang
    gtdang committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9497a90 View commit details
    Browse the repository at this point in the history

  2. test: changed test_gui_run_simulation_mpi to use the default network 

    -The test fixture network was not working with MPI. Presumably because the smaller network used in the fixture was not compatible with the multiprocessing subprocess call.

-We were encountering an error at the h.finitialize step of network_builder > _simulate_single_trial when using the fixture network. The error was within neuron: "NEURON: mindelay is 0 (or less than dt for fixed step method)".
    @gtdang
    gtdang committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0b3def1 View commit details
    Browse the repository at this point in the history