[WHM] Track lost Divine Caress uses (xivanalysis#2031)

* Add module for tracking unused Divine Grace opportunities - but it bork

* Change module structure, fix wrong action, still borked.

* Attempt to add debug messages and fix some other messes

* Fix severity tiers, remove debug, finalize changes

* Add changelog entry

src/data/ACTIONS/root/WHM.ts

@@ -8,7 +8,7 @@ export const WHM = ensureActions({
 		name: 'Divine Caress',
 		icon: iconUrl(2128),
 		cooldown: 1000,
-		statusesApplied: ['DIVINE_GRACE'],
+		statusesApplied: ['DIVINE_CARESS'],
 	},
 	MEDICA_III: {
 		id: 37010,

src/data/STATUSES/root/WHM.ts

@@ -31,6 +31,7 @@ export const WHM = ensureStatuses({
 		name: 'Sacred Sight',
 		icon: iconUrl(18669),
 		duration: 30000,
+		stacksApplied: 3,
 	},
 	LITURGY_OF_THE_BELL: {
 		id: 2709,

src/parser/jobs/whm/changelog.tsx

@@ -1,10 +1,15 @@
-// import CONTRIBUTORS from 'data/CONTRIBUTORS'
-// import React from 'react'
+import CONTRIBUTORS from 'data/CONTRIBUTORS'
+import React from 'react'
 
 export const changelog = [
 	// {
 	// 	date: new Date('2021-11-19'),
 	// 	Changes: () => <>The changes you made</>,
 	// 	contributors: [CONTRIBUTORS.YOU],
 	// },
+	{
+		date: new Date('2024-07-22'),
+		Changes: () => <>Added tracking for unused Divine Caress procs</>,
+		contributors: [CONTRIBUTORS.INNI],
+	},
 ]

src/parser/jobs/whm/index.tsx

@@ -1,6 +1,5 @@
 import {t} from '@lingui/macro'
 import TransMarkdown from 'components/ui/TransMarkdown'
-// import CONTRIBUTORS, {ROLES} from 'data/CONTRIBUTORS'
 import CONTRIBUTORS, {ROLES} from 'data/CONTRIBUTORS'
 import {Meta} from 'parser/core/Meta'
 import React from 'react'

src/parser/jobs/whm/modules/DivineCaress.tsx

@@ -0,0 +1,25 @@
+import {Trans} from '@lingui/react'
+import {Procs as CoreProcs} from 'parser/core/modules/Procs'
+import {SEVERITY} from 'parser/core/modules/Suggestions'
+import React from 'react'
+
+export class DivineCaress extends CoreProcs {
+
+	//Track Divine Caress as the only status currently
+	override trackedProcs = [
+		{
+			procStatus: this.data.statuses.DIVINE_GRACE,
+			consumeActions: [this.data.actions.DIVINE_CARESS],
+		},
+	]
+	override showDroppedProcSuggestion = true;
+	override droppedProcIcon = this.data.actions.DIVINE_CARESS.icon;
+	override droppedProcContent =
+		<Trans id="whm.procs.suggestions.dropped-divine-caress.content">
+			Try to use Divine Caress whenever you have used Temperance. It is a free, groupwide oGCD shield and heal over time!
+		</Trans>
+	override droppedProcSeverityTiers = {
+		1: SEVERITY.MEDIUM,
+		3: SEVERITY.MAJOR,
+	}
+}

src/parser/jobs/whm/modules/index.ts

@@ -1,6 +1,7 @@
 import {ActionTimeline} from './ActionTimeline'
 import {CastTime} from './CastTime'
 import {Defensives} from './Defensives'
+import {DivineCaress} from './DivineCaress'
 import {DoTs} from './DoTs'
 import {Interrupts} from './Interrupts'
 import {Lilies} from './Lilies'
@@ -14,6 +15,7 @@ export default [
 	ActionTimeline,
 	CastTime,
 	Defensives,
+	DivineCaress,
 	DoTs,
 	Interrupts,
 	Lilies,