add render prop to NavigationItem (#3279)
#3417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 98555ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mark-tate
force-pushed
the
3279-pass-props-to-navigation-item
branch
2 times, most recently
from
7a77190 to
6aec97a
Compare
mark-tate
force-pushed
the
3279-pass-props-to-navigation-item
branch
from
6aec97a to
60c3bf4
Compare
1 task
JoanaMMoreira
previously approved these changes
May 30, 2024
origami-z
reviewed
Jun 6, 2024
origami-z
reviewed
Jun 6, 2024
joshwooding
requested changes
Jun 6, 2024
mark-tate
force-pushed
the
3279-pass-props-to-navigation-item
branch
2 times, most recently
from
a14f302 to
492fdd4
Compare
mark-tate
commented
Jun 18, 2024
mark-tate
force-pushed
the
3279-pass-props-to-navigation-item
branch
from
492fdd4 to
38d10c2
Compare
joshwooding
reviewed
Jun 19, 2024
joshwooding
reviewed
Jun 19, 2024
joshwooding
reviewed
Jun 19, 2024
joshwooding
reviewed
Jun 19, 2024
packages/core/src/__tests__/__e2e__/navigation-item/NavigationItem.cy.tsx
Show resolved
Hide resolved
joshwooding
reviewed
Jun 19, 2024
packages/core/src/__tests__/__e2e__/navigation-item/NavigationItem.cy.tsx
Outdated
Show resolved
Hide resolved
mark-tate
force-pushed
the
3279-pass-props-to-navigation-item
branch
from
aa84ff5 to
510fb0c
Compare
Co-authored-by: Josh Wooding <[email protected]>
- test the DOM element exists in RenderElement tests - move the CustomLinkComponent out of the example, to avoid folks copying it - render element docs page broken by linter, props merging section now appears
mark-tate
force-pushed
the
3279-pass-props-to-navigation-item
branch
from
8a58031 to
85ed339
Compare
origami-z
previously approved these changes
Jul 1, 2024
Fercas123
previously approved these changes
Jul 1, 2024
joshwooding
reviewed
Jul 3, 2024
joshwooding
reviewed
Jul 3, 2024
joshwooding
approved these changes
Jul 3, 2024
joshwooding
reviewed
Jul 4, 2024
joshwooding
reviewed
Jul 4, 2024
joshwooding
reviewed
Jul 4, 2024
joshwooding
reviewed
Jul 4, 2024
Co-authored-by: Josh Wooding <[email protected]>
Co-authored-by: Josh Wooding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renderprop enables the substitution of the default anchor tag with an alternate link, such as React Router, facilitating integration with routing libraries.