Bordered Buttons #3648

Vineet119 · 2024-06-26T13:40:01Z

No description provided.

changeset-bot · 2024-06-26T13:40:05Z

🦋 Changeset detected

Latest commit: 286c974

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@salt-ds/core	Minor
@salt-ds/theme	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-06-26T13:40:06Z

@Vineet119 is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

packages/theme/css/characteristics/actionable.css

vercel · 2024-06-28T15:06:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
saltdesignsystem	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 31, 2024 3:19pm

packages/theme/css/characteristics/actionable-next.css

packages/theme/css/characteristics/actionable.css

pseys · 2024-07-22T08:40:03Z

I'm reviewing the buttons in Storybook now.

packages/core/src/button/Button.css

packages/core/src/file-drop-zone/FileDropZoneTrigger.tsx

packages/theme/css/characteristics/actionable-next.css

site/docs/components/button/examples.mdx

site/docs/components/button/index.mdx

…ssary files

This reverts commit 7d874bb.

Vineet119 changed the title ~~bordered-button-initial commit~~ bordered-button-In Progess Jun 26, 2024

Vineet119 changed the title ~~bordered-button-In Progess~~ bordered-button-In Progress Jun 26, 2024

joshwooding marked this pull request as draft June 26, 2024 15:54

joshwooding changed the title ~~bordered-button-In Progress~~ Bordered Buttons Jun 28, 2024

pseys reviewed Jun 28, 2024

View reviewed changes

packages/theme/css/characteristics/actionable.css Outdated Show resolved Hide resolved

joshwooding reviewed Jun 28, 2024

View reviewed changes

packages/theme/css/characteristics/actionable-next.css Outdated Show resolved Hide resolved

joshwooding reviewed Jun 28, 2024

View reviewed changes

packages/theme/css/characteristics/actionable.css Outdated Show resolved Hide resolved

joshwooding reviewed Jun 28, 2024

View reviewed changes

packages/theme/css/characteristics/actionable.css Outdated Show resolved Hide resolved

joshwooding force-pushed the bordered-button branch from 40fdd3b to de46b8e Compare June 28, 2024 15:43

vercel bot deployed to Preview June 28, 2024 15:56 View deployment

vercel bot had a problem deploying to Preview July 18, 2024 14:39 Failure

vercel bot deployed to Preview July 19, 2024 08:41 View deployment

vercel bot deployed to Preview July 22, 2024 10:39 View deployment

pseys reviewed Jul 22, 2024

View reviewed changes

packages/core/src/button/Button.css Outdated Show resolved Hide resolved

vercel bot deployed to Preview July 23, 2024 09:55 View deployment

joshwooding reviewed Jul 24, 2024

View reviewed changes

packages/core/src/file-drop-zone/FileDropZoneTrigger.tsx Outdated Show resolved Hide resolved

joshwooding reviewed Jul 24, 2024

View reviewed changes

packages/theme/css/characteristics/actionable-next.css Outdated Show resolved Hide resolved

joshwooding force-pushed the bordered-button branch 3 times, most recently from 32157c3 to 85c95ca Compare July 25, 2024 07:01

vercel bot deployed to Preview July 25, 2024 07:12 View deployment

joshwooding reviewed Jul 25, 2024

View reviewed changes

site/docs/components/button/examples.mdx Outdated Show resolved Hide resolved

vercel bot deployed to Preview July 26, 2024 11:06 View deployment

joshwooding reviewed Jul 26, 2024

View reviewed changes

site/docs/components/button/index.mdx Outdated Show resolved Hide resolved

joshwooding force-pushed the bordered-button branch from ed98080 to 2265f7b Compare July 26, 2024 16:23

vercel bot deployed to Preview July 26, 2024 16:42 View deployment

github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 29, 2024

joshwooding previously approved these changes Jul 29, 2024

View reviewed changes

Vineet119 dismissed joshwooding’s stale review via fa70cd1 July 30, 2024 13:28

Vineet119 force-pushed the bordered-button branch from fa70cd1 to 2c4f63a Compare July 30, 2024 13:30

vercel bot deployed to Preview July 30, 2024 15:32 View deployment

design review comments addressed for site examples and removed unnece…

0c3f475

…ssary files

joshwooding force-pushed the bordered-button branch from ee833ab to 0c3f475 Compare July 31, 2024 07:42

vercel bot deployed to Preview July 31, 2024 07:48 View deployment

Updates

8bb297c

vercel bot deployed to Preview July 31, 2024 07:56 View deployment

joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 31, 2024

github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 31, 2024

joshwooding previously approved these changes Jul 31, 2024

View reviewed changes

joshwooding dismissed their stale review via fbcf1ed July 31, 2024 13:25

Update appearance best practices

4184f54

joshwooding force-pushed the bordered-button branch from fbcf1ed to 4184f54 Compare July 31, 2024 13:43

vercel bot deployed to Preview July 31, 2024 13:49 View deployment

joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 31, 2024

github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 31, 2024

joshwooding previously approved these changes Jul 31, 2024

View reviewed changes

Update docs

286c974

joshwooding dismissed their stale review via 286c974 July 31, 2024 15:12

vercel bot deployed to Preview July 31, 2024 15:19 View deployment

joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 31, 2024

github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 31, 2024

dplsek approved these changes Jul 31, 2024

View reviewed changes

joshwooding approved these changes Jul 31, 2024

View reviewed changes

joshwooding merged commit 7d874bb into jpmorganchase:main Jul 31, 2024
16 checks passed

origami-z added a commit that referenced this pull request Aug 8, 2024

Revert "Bordered Buttons (#3648)"

2237da5

This reverts commit 7d874bb.

origami-z mentioned this pull request Sep 10, 2024

New button sentiment and appearance #4067

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bordered Buttons #3648

Bordered Buttons #3648

Vineet119 commented Jun 26, 2024

changeset-bot bot commented Jun 26, 2024 •

edited

Loading

vercel bot commented Jun 26, 2024

vercel bot commented Jun 28, 2024 •

edited

Loading

pseys commented Jul 22, 2024

Bordered Buttons #3648

Bordered Buttons #3648

Conversation

Vineet119 commented Jun 26, 2024

changeset-bot bot commented Jun 26, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Jun 26, 2024

vercel bot commented Jun 28, 2024 • edited Loading

pseys commented Jul 22, 2024

changeset-bot bot commented Jun 26, 2024 •

edited

Loading

vercel bot commented Jun 28, 2024 •

edited

Loading