-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transloco): 🎸 add option to not change the casing of the provided scope #794
feat(transloco): 🎸 add option to not change the casing of the provided scope #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, nice feature! left a couple of comments 🙂
I will squash all the commits once we get to a point where the PR Is final, but I now left them there so you can see changes a bit more easy. |
ec2783b
to
f41cd3b
Compare
76f7432
to
73777bf
Compare
73777bf
to
4705f4c
Compare
@shaharkazaz I think we're good to go. |
@maartentibau Can you please update from master? |
4705f4c
to
fd0c4ab
Compare
Done 🚀 |
2efec71
to
9a4e36b
Compare
9a4e36b
to
1bd2ee0
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the
scope
is being altered by thetoCamelCase
helper method. This creates the issue that if you provide ascope
where you would like to have the first character not to be changed OR just the casing in general you can only do this by providing analias
.e.g
{ scope: 'FOOBAR', alias: 'FOOBAR' }
Issue Number: N/A
What is the new behavior?
This feature enabled the possibility to only provide the scope and the casing of it will not be altered, so you can just use this:
{ scope: 'FOOBAR' }
or{ scope: 'F-OO-BaR' } --> will be transformed to
{ scope: 'FOOBaR' }`Does this PR introduce a breaking change?
Other information