fix(modal): add class on mount and fix backdrop #572
Merged
+175
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jowjow22
changed the title
jowjow22
commented
Sep 27, 2024
|
jowjow22
requested review from
igorwessel and
felipefialho
and removed request for
igorwessel
tassioFront
approved these changes
Sep 30, 2024
lupy100
approved these changes
Sep 30, 2024
tiago-dela-rosa
approved these changes
Sep 30, 2024
felipefialho
approved these changes
Sep 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
Fix modal scroll backdrop and expose isOpen Property to control opening of modal without trigger
What impacts?
The modal component and it's scroll behaviour
Reversal plan
revert to the previous release
Evidences
Media(images, gifs or videos) that shows the result of your work.