feat(select): add validation in select tag #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tassioFront
reviewed
Oct 9, 2024
tassioFront
approved these changes
Oct 14, 2024
gabrielduete
approved these changes
Oct 15, 2024
gabrielduete
requested review from
a team,
jowjow22,
anabrook,
matheus-rosa-jsm and
jeosadache
and removed request for
a team
igorwessel
approved these changes
Oct 16, 2024
mauriciomutte
approved these changes
Oct 17, 2024
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
Adds a validation when the element to attach the tag to is not found in the select options.
What impacts?
Select component
Reversal plan
Rollback this PR
Evidences
Sentry triggered some errors related to this code snippet and with potential navigation crash. These errors were not reproducible because they occur on specific devices. However, to work around the problem and prevent navigation crashes, the changes in this PR were made.
There were no visual changes. The change occurs if there is any issue when searching for the element to attach the tag and it is not found, return to the view without adding the tag.