Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(select): add validation in select tag #590

Merged
merged 2 commits into from
Oct 21, 2024
Merged

feat(select): add validation in select tag #590

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
859fb93
feat: add validation in select tag
Natalie9 Oct 9, 2024
7c880c5
Merge branch 'main' into fix/validation-tag-select
Natalie9 Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/core/src/components/select/select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,14 @@ export class AtomSelect {
const optionElement =
this.getElementByTag(itemElement, 'ion-radio') ||
this.getElementByTag(itemElement, 'ion-checkbox')

if (!optionElement?.shadowRoot) return
Natalie9 marked this conversation as resolved.
Show resolved Hide resolved

const optionShadowRoot = optionElement.shadowRoot
.firstElementChild as HTMLElement

if (!optionShadowRoot) return

const firstElementInOption =
optionShadowRoot.firstElementChild as HTMLElement

Expand Down
Loading