Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

direnv: Use the same nix package #66

Merged
merged 2 commits into from
Aug 26, 2024
Merged

direnv: Use the same nix package #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d18024
direnv: Use the same nix package
srid Aug 26, 2024
89fb527
Update default.nix
srid Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion home/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ flake, pkgs, ... }:
{ flake, config, pkgs, ... }:
{
imports = [
./nix-index.nix
Expand Down Expand Up @@ -121,6 +121,7 @@
# https://nixos.asia/en/direnv
direnv = {
enable = true;
package = config.nix.package;
nix-direnv.enable = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it nix-direnv.package instead of direnv.package

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, this PR broke stuff.

But your change is also not correct?

image image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already using config.nix.package. I'll revert this PR for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this was my fault for not paying attention to Rana's actual change:

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srid the nix-direnv configuration above is from nixos modules and not from home-manager.

This has to be fixed in home-manager to match nixos module.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's upstream that to hm: #68

config.global = {
# Make direnv messages less verbose
Expand Down
Loading